tree 8f9fffb1ddf27832d9a31cee54b6651431723e91
parent 9d9d645409e65069c5267422ac9d8d25ca96258d
author Willy Tarreau <w@1wt.eu> 1582274679 +0100
committer Willy Tarreau <w@1wt.eu> 1582280472 +0100
encoding latin1

BUG/MINOR: mux: do not call conn_xprt_stop_recv() on buffer shortage

In H1/H2/FCGI, the *_get_buf() functions try to disable receipt of data
when there's no buffer available. But they do so at the lowest possible
level, which is unrelated to the upper transport layers which may still
be trying to feed data based on subscription. The correct approach here
would theorically be to only disable subscription, though when we get
there, the subscription will already have been dropped, so we can safely
just remove that call.

It's unlikely that this could have had any practical impact, as the upper
xprt layer would call this callback which would fail an not resubscribe.
Having the lowest layer disabled would just be temporary since when
re-enabling reading, a subscribe at the end of data would re-enable it.

Backport should not harm but seems useless at this point.