MINOR: server: move actconns to the per-thread structure
The actconns list creates massive contention on low server counts because
it's in fact a list of streams using a server, all threads compete on the
list's head and it's still possible to see some watchdog panics on 48
threads under extreme contention with 47 threads trying to add and one
thread trying to delete.
Moving this list per thread is trivial because it's only used by
srv_shutdown_streams(), which simply required to iterate over the list.
The field was renamed to "streams" as it's really a list of streams
rather than a list of connections.
diff --git a/src/server.c b/src/server.c
index 5844c63..04d2347 100644
--- a/src/server.c
+++ b/src/server.c
@@ -891,10 +891,12 @@
{
struct stream *stream;
struct mt_list *elt1, elt2;
+ int thr;
- mt_list_for_each_entry_safe(stream, &srv->actconns, by_srv, elt1, elt2)
- if (stream->srv_conn == srv)
- stream_shutdown(stream, why);
+ for (thr = 0; thr < global.nbthread; thr++)
+ mt_list_for_each_entry_safe(stream, &srv->per_thr[thr].streams, by_srv, elt1, elt2)
+ if (stream->srv_conn == srv)
+ stream_shutdown(stream, why);
}
/* Shutdown all connections of all backup servers of a proxy. The caller must
@@ -1750,7 +1752,6 @@
srv->obj_type = OBJ_TYPE_SERVER;
srv->proxy = proxy;
- MT_LIST_INIT(&srv->actconns);
srv->pendconns = EB_ROOT;
LIST_ADDQ(&servers_list, &srv->global_list);