BUG/MEDIUM: proxy: must not try to stop disabled proxies upon reload
Hervé Commowick reported an issue : haproxy dies in a segfault during a
soft restart if it tries to pause a disabled proxy. This is because disabled
proxies have no management task so we must not wake the task up. This could
easily remain unnoticed since the old process was expected to go away, so
having it go away faster was not really troubling. However, with sync peers,
it is obvious that there is no peer sync during this reload.
This issue has been introduced in 1.5-dev7 with the removal of the
maintain_proxies() function. No backport is needed.
diff --git a/src/proxy.c b/src/proxy.c
index 8db70b6..820be2f 100644
--- a/src/proxy.c
+++ b/src/proxy.c
@@ -609,7 +609,8 @@
task_wakeup(p->table.sync_task, TASK_WOKEN_MSG);
/* wake every proxy task up so that they can handle the stopping */
- task_wakeup(p->task, TASK_WOKEN_MSG);
+ if (p->task)
+ task_wakeup(p->task, TASK_WOKEN_MSG);
p = p->next;
}