CLEANUP: queue: Remove useless tests on p or pp in pendconn_process_next_strm()
This patch removes unecessary tests on p or pp pointers in
pendconn_process_next_strm() function. This should make cppcheck happy and
avoid false report of null pointer dereference.
This patch should fix the issue #1036.
diff --git a/src/queue.c b/src/queue.c
index 19b99a5..8157809 100644
--- a/src/queue.c
+++ b/src/queue.c
@@ -281,12 +281,12 @@
if (!p && !pp)
return 0;
-
- if (p && !pp)
- goto use_p;
+ else if (!pp)
+ goto use_p; /* p != NULL */
+ else if (!p)
+ goto use_pp; /* pp != NULL */
- if (pp && !p)
- goto use_pp;
+ /* p != NULL && pp != NULL*/
if (KEY_CLASS(p->node.key) < KEY_CLASS(pp->node.key))
goto use_p;