commit c8cfa7b4f304b1ec26f0a5e995558d78d35e7e7c
author Dragan Dosen <ddosen@haproxy.com> Mon Sep 28 13:28:21 2015 +0200
committer Willy Tarreau <w@1wt.eu> Mon Sep 28 18:27:45 2015 +0200
tree 731b9ba3aa1bbf68f88ef56ccb4668eb73157810
parent 7ad3154cb81a1e282b528574157f1a0f810149c8

MEDIUM: logs: have global.log_send_hostname not contain the trailing space

This patch unifies global.log_send_hostname addition in the log header
processing.

src/log.c

diff --git a/src/log.c b/src/log.c
index 1829696..18a2006 100644
--- a/src/log.c
+++ b/src/log.c
@@ -158,8 +158,8 @@
 /* Common printf format strings for hostname, log_tag and pid used in all
  * outgoing syslog messages.
  */
-char default_host_tag_pid_log_format[] = "%s%s[%d]: ";
-char rfc5424_host_tag_pid_log_format[] = "%s%s %d - ";
+static char default_host_tag_pid_log_format[] = "%s%s%s[%d]: ";
+static char rfc5424_host_tag_pid_log_format[] = "%s%s%s %d - ";
 
 /* Default string used for structured-data part in RFC5424 formatted
  * syslog messages.
@@ -780,12 +780,26 @@
 	return ret;
 }
 
-char *lf_host_tag_pid(char *dst, const char *format, const char *hostname, const char *log_tag, int pid, size_t size)
+char *lf_host_tag_pid(char *dst, int format, const char *hostname, const char *log_tag, int pid, size_t size)
 {
 	char *ret = dst;
+	char *fmt;
 	int iret;
 
-	iret = snprintf(dst, size, format, hostname, log_tag, pid);
+	switch (format) {
+	case LOG_FORMAT_RFC3164:
+		fmt = default_host_tag_pid_log_format;
+		break;
+
+	case LOG_FORMAT_RFC5424:
+		fmt = rfc5424_host_tag_pid_log_format;
+		break;
+
+	default:
+		return NULL;
+	}
+
+	iret = snprintf(dst, size, fmt, hostname, strlen(hostname) ? " " : "", log_tag, pid);
 	if (iret < 0 || iret > size)
 		return NULL;
 	ret += iret;