BUG/MINOR: mux-quic: refactor uni streams TX/send H3 SETTINGS
Remove the unneeded skip over unidirectional streams in qc_send(). This
unify sending for both uni and bidi streams.
In fact, the only local unidirectional streams in use for the moment is
the H3 Control stream responsible of SETTINGS emission. The frame was
already properly generated in qcs.tx.buf, but not send due to stream
skip in qc_send(). Now, there is no need to ignore uni streams so remove
this condition.
This fixes the emission of H3 settings which is now properly emitted.
Uni and bidi streams use the same set of funtcions for sending. One of
the most notable gain is that flow-control is now enforced for uni
streams.
diff --git a/src/h3.c b/src/h3.c
index c2dfd00..317e666 100644
--- a/src/h3.c
+++ b/src/h3.c
@@ -870,7 +870,6 @@
if (!h3c->lctrl.qcs)
return 0;
- /* Wakeup ->lctrl uni-stream */
h3_control_send(&h3c->lctrl, h3c);
return 1;
@@ -967,7 +966,7 @@
!h3_uqs_init(&h3c->rctrl, h3c, h3_control_recv, h3_uqs_task))
goto fail_no_h3_ruqs;
- if (!h3_uqs_init(&h3c->lctrl, h3c, h3_control_send, h3_uqs_task) ||
+ if (!h3_uqs_init(&h3c->lctrl, h3c, NULL, h3_uqs_task) ||
!h3_uqs_init(&h3c->lqpack_enc, h3c, NULL, h3_uqs_task) ||
!h3_uqs_init(&h3c->lqpack_dec, h3c, NULL, h3_uqs_task))
goto fail_no_h3_luqs;