commit c18e244515cdf860a3be59f0fc5622b8294099e7
author Tim Duesterhus <tim@bastelstu.be> Sat Apr 22 17:47:33 2023 +0200
committer Willy Tarreau <w@1wt.eu> Sun Apr 23 00:28:25 2023 +0200
tree e78112f0b25071debf21b51be3e865f5d7c55f02
parent b1ec21d259c72559e2d170a09efc059d9fc58347

CLEANUP: Stop checking the pointer before calling `pool_free()`

Changes performed with this Coccinelle patch:

    @@
    expression e;
    expression p;
    @@

    - if (e != NULL) {
    	pool_free(p, e);
    - }

    @@
    expression e;
    expression p;
    @@

    - if (e) {
    	pool_free(p, e);
    - }

    @@
    expression e;
    expression p;
    @@

    - if (e)
    	pool_free(p, e);

    @@
    expression e;
    expression p;
    @@

    - if (e != NULL)
    	pool_free(p, e);

src/dns.c

diff --git a/src/dns.c b/src/dns.c
index a48eadd..b103c86 100644
--- a/src/dns.c
+++ b/src/dns.c
@@ -777,10 +777,8 @@
 
 void dns_session_free(struct dns_session *ds)
 {
-	if (ds->rx_msg.area)
-		pool_free(dns_msg_buf, ds->rx_msg.area);
-	if (ds->tx_ring_area)
-		pool_free(dns_msg_buf, ds->tx_ring_area);
+	pool_free(dns_msg_buf, ds->rx_msg.area);
+	pool_free(dns_msg_buf, ds->tx_ring_area);
 	if (ds->task_exp)
 		task_destroy(ds->task_exp);
 
@@ -1084,10 +1082,8 @@
 error:
 	if (ds->task_exp)
 		task_destroy(ds->task_exp);
-	if (ds->rx_msg.area)
-		pool_free(dns_msg_buf, ds->rx_msg.area);
-	if (ds->tx_ring_area)
-		pool_free(dns_msg_buf, ds->tx_ring_area);
+	pool_free(dns_msg_buf, ds->rx_msg.area);
+	pool_free(dns_msg_buf, ds->tx_ring_area);
 
 	pool_free(dns_session_pool, ds);