BUILD: http: silence an uninitialized warning affecting gcc-5
When building with gcc-5, one can see this warning:
src/http_fetch.c: In function 'smp_fetch_meth':
src/http_fetch.c:356:6: warning: 'htx' may be used uninitialized in this function [-Wmaybe-uninitialized]
sl = http_get_stline(htx);
^
It's wrong since the only way to reach this code is to have met the
same condition a few lines before and initialized the htx variable.
The reason in fact is that the same test happens on different variables
of distinct types, so the compiler possibly doesn't know that the
condition is the same. Newer gcc versions do not have this problem.
Let's just move the assignment earlier and have the exact same test,
as it's sufficient to shut this up. This may have to be backported
to 2.6 since the code is the same there.
(cherry picked from commit a88e8bf4283cea6d21eb88ba819316185e1c3465)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit 1a175bde8b5c50a7a21ba220d8bcae0b41f81f5b)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit 5460b7df174abfe624c80359a3df95c9a85310c6)
Signed-off-by: Willy Tarreau <w@1wt.eu>
1 file changed