tree 237b9686a0e860b02abdf67baa6415d0ad21f37b
parent 556a94ac9dd3f0e31138ffd56acd2f6f52d8b5f2
author Christopher Faulet <cfaulet@haproxy.com> 1573831906 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1579768100 +0100

BUG/MINOR: http-ana/filters: Wait end of the http_end callback for all filters

Filters may define the "http_end" callback, called at the end of the analysis of
any HTTP messages. It is called at the end of the payload forwarding and it can
interrupt the stream processing. So we must be sure to not remove the XFER_BODY
analyzers while there is still at least filter in progress on this callback.

Unfortunatly, once the request and the response are borh in the DONE or the
TUNNEL mode, we consider the XFER_BODY analyzer has finished its processing on
both sides. So it is possible to prematurely interrupt the execution of the
filters "http_end" callback.

To fix this bug, we switch a message in the ENDING state. It is then switched in
DONE/TUNNEL mode only after the execution of the filters "http_end" callback.

This patch must be backported (and adapted) to 2.1, 2.0 and 1.9. The legacy HTTP
mode shoud probaly be fixed too.

(cherry picked from commit 1a3e0279c6079174288e2e3fbbf09e530ff221c5)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 8ece0801d813d6f821dabde13f7a74759dd95ee4)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>