tree 65a2d8059e4eba3ca321133734a901c27a263919
parent ea489aa18caacf057880c67b933689c363307a23
author Christopher Faulet <cfaulet@haproxy.com> 1634561569 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1638454778 +0100

BUG/MEDIUM: cli: Properly set stream analyzers to process one command at a time

The proxy used by the master CLI is an internal proxy and no filter are
registered on it. Thus, there is no reason to take care to set or unset
filter analyzers in the master CLI analyzers. AN_REQ_FLT_END was set on the
request channel to prevent the infinite forward and be sure to be able to
process one commande at a time. However, the only work because
CF_FLT_ANALYZE flag was used by error as a channel analyzer instead of a
channel flag. This erroneously set AN_RES_FLT_END on the request channel,
that really prevent the infinite forward, be side effet.

In fact, We must avoid this kind of trick because this only work by chance
and may be source of bugs in future. Instead, we must always keep the CLI
request analyzer and add an early return if the response is not fully
processed. It happens when the CLI response analyzer is set.

This patch must be backported as far as 2.0.

(cherry picked from commit d98da3bc902fcde45909eee13bdf94c99b19647d)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit b5ec486a9b40e61e6f6fb39182c4222d7d13f4e7)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>