BUG/MEDIUM: stick-table: Wrong stick-table backends parsing.
When parsing references to stick-tables declared as backends, they are added to
a list of proxies (they are proxies!) which refer to this stick-tables.
Before this patch we added them to these list without checking they were already
present, making the silly hypothesis the actions/sample were checked/resolved in the same
order the proxies are parsed.
This patch implement a simple inline function to in_proxies_list() to test
the presence of a proxy in a list of proxies. We use this function when resolving
/checking samples/actions.
This bug was introduced by 015e4d7 commit.
Must be backported to 2.0.
diff --git a/include/proto/proxy.h b/include/proto/proxy.h
index c75c0da..558718b 100644
--- a/include/proto/proxy.h
+++ b/include/proto/proxy.h
@@ -184,6 +184,21 @@
}
return 0;
}
+
+/* Return 1 if <p> proxy is in <list> list of proxies which are also stick-tables,
+ * 0 if not.
+ */
+static inline int in_proxies_list(struct proxy *list, struct proxy *proxy)
+{
+ struct proxy *p;
+
+ for (p = list; p; p = p->next_stkt_ref)
+ if (proxy == p)
+ return 1;
+
+ return 0;
+}
+
#endif /* _PROTO_PROXY_H */
/*
diff --git a/src/action.c b/src/action.c
index 5454242..7684202 100644
--- a/src/action.c
+++ b/src/action.c
@@ -56,7 +56,7 @@
return 0;
}
else {
- if (target->proxies_list != px) {
+ if (!in_proxies_list(target->proxies_list, px)) {
px->next_stkt_ref = target->proxies_list;
target->proxies_list = px;
}
diff --git a/src/sample.c b/src/sample.c
index 94c605f..6327b6b 100644
--- a/src/sample.c
+++ b/src/sample.c
@@ -1274,7 +1274,7 @@
break;
}
- if (t->proxies_list != p) {
+ if (!in_proxies_list(t->proxies_list, p)) {
p->next_stkt_ref = t->proxies_list;
t->proxies_list = p;
}