BUG/MINOR: server: report correct error message for invalid port on "socks4"
The socks4 keyword parser was a bit too much copy-pasted, it only checks
for a null port and reports "invalid range". Let's properly check for the
1-65535 range and report the correct error.
It may be backported everywhere "socks4" is present (2.0).
(cherry picked from commit 9743f709d03c036b7a6da2fb260d0e77f9e04a3d)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit e96489ea5e0408d852fc1dd4318926923916c230)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit f75b42ae39b57c5ecdab5f4969241ab882aab88e)
Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com>
diff --git a/src/server.c b/src/server.c
index 5490216..ff5e69c 100644
--- a/src/server.c
+++ b/src/server.c
@@ -963,8 +963,8 @@
goto err;
}
- if (!port_low) {
- ha_alert("'%s': invalid port range %d-%d.\n", args[*cur_arg], port_low, port_high);
+ if (port_low <= 0 || port_low > 65535) {
+ ha_alert("'%s': invalid port %d.\n", args[*cur_arg], port_low);
goto err;
}