BUG/MINOR: lua: initialize sample before using it
Memset the sample before using it through hlua_lua2smp. This function is
ORing the smp.flags, so this field need to be cleared before its use.
This was reported by a coverity warning.
Fixes the github issue #929.
This bug can be backported up to 1.8.
diff --git a/src/hlua.c b/src/hlua.c
index 9616a75..97dcebd 100644
--- a/src/hlua.c
+++ b/src/hlua.c
@@ -3505,6 +3505,7 @@
}
/* Initialise the sample. */
+ memset(&smp, 0, sizeof(smp));
if (!hlua_lua2smp(L, 2, &smp)) {
hlua_pusherror(L, "error in the input argument");
goto error;
@@ -3649,6 +3650,7 @@
s = appctx->htxn.s;
/* Converts the third argument in a sample. */
+ memset(&smp, 0, sizeof(smp));
hlua_lua2smp(L, 3, &smp);
/* Store the sample in a variable. */
@@ -4133,6 +4135,7 @@
s = appctx->htxn.s;
/* Converts the third argument in a sample. */
+ memset(&smp, 0, sizeof(smp));
hlua_lua2smp(L, 3, &smp);
/* Store the sample in a variable. */
@@ -5225,6 +5228,7 @@
name = MAY_LJMP(luaL_checklstring(L, 2, &len));
/* Converts the third argument in a sample. */
+ memset(&smp, 0, sizeof(smp));
hlua_lua2smp(L, 3, &smp);
/* Store the sample in a variable. */