tree f3b0290759928da9e60e26cc52346cb67ddea1b9
parent 2eb9920717c00a2af01d80540d65586e6bdc9733
author Christopher Faulet <cfaulet@haproxy.com> 1618471682 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1619691605 +0200

BUG/MINOR: http-fetch: Make method smp safe if headers were already forwarded

When method sample fetch is called, if an exotic method is found
(HTTP_METH_OTHER), when smp_prefetch_htx() is called, we must be sure the
start-line is still there. Otherwise, HAproxy may crash because of a NULL
pointer dereference, for instance if the method sample fetch is used inside
a unique-id format string. Indeed, the unique id may be generated when the
log message is emitted. At this stage, the request channel is empty.

This patch must be backported as far as 2.0. But the bug exists in all
stable versions for the legacy HTTP mode too. Thus it must be adapted to the
legacy HTTP mode and backported to all other stable versions.

(cherry picked from commit 6f97a611c83d7135d77407f7327980994413b842)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 1edd927c3d9f2257e053e8a5c93e5edaa1f9e91b)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 2e4aaea20d10324c66d936ba8ce892c6bab4200e)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>