MEDIUM: connection: move the send_proxy offset to the connection
Till now the send_proxy_ofs field remained in the stream interface,
but since the dynamic allocation of the connection, it makes a lot
of sense to move that into the connection instead of the stream
interface, since it will not be statically allocated for each
session.
Also, it turns out that moving it to the connection fils an alignment
hole on 64 bit architectures so it does not consume more memory, and
removing it from the stream interface was an opportunity to correctly
reorder fields and reduce the stream interface's size from 160 to 144
bytes (-10%). This is 32 bytes saved per session.
diff --git a/include/proto/stream_interface.h b/include/proto/stream_interface.h
index 2c69649..46d0c72 100644
--- a/include/proto/stream_interface.h
+++ b/include/proto/stream_interface.h
@@ -54,7 +54,6 @@
si->owner = owner;
si->err_type = SI_ET_NONE;
si->conn_retries = 0; /* used for logging too */
- si->send_proxy_ofs = 0;
si->exp = TICK_ETERNITY;
si->flags = SI_FL_NONE;
si->end = NULL;
@@ -202,7 +201,7 @@
if (unlikely(!conn || !conn->ctrl || !conn->ctrl->connect))
return SN_ERR_INTERNAL;
- ret = conn->ctrl->connect(conn, !channel_is_empty(si->ob), !!si->send_proxy_ofs);
+ ret = conn->ctrl->connect(conn, !channel_is_empty(si->ob), !!conn->send_proxy_ofs);
if (ret != SN_ERR_NONE)
return ret;
@@ -211,7 +210,7 @@
conn_get_from_addr(conn);
/* Prepare to send a few handshakes related to the on-wire protocol. */
- if (si->send_proxy_ofs)
+ if (conn->send_proxy_ofs)
conn->flags |= CO_FL_SI_SEND_PROXY;
/* we need to be notified about connection establishment */