tree f586b1c8705b90cd8c42251cd013f48a1680a4b2
parent 79a5693c58056d946bb5a17c8818f606abfdee12
author Christopher Faulet <cfaulet@haproxy.com> 1573133272 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1573138881 +0100

BUG/MEDIUM: stream: Be sure to release allocated captures for TCP streams

All TCP and HTTP captures are stored in 2 arrays, one for the request and
another for the response. In HAPRoxy 1.5, these arrays are part of the HTTP
transaction and thus are released during its cleanup. Because in this version,
the transaction is part of the stream (in 1.5, streams are still called
sessions), the cleanup is always performed, for HTTP and TCP streams.

In HAProxy 1.6, the HTTP transaction was moved out from the stream and is now
dynamically allocated only when required (becaues of an HTTP proxy or an HTTP
sample fetch). In addition, still in 1.6, the captures arrays were moved from
the HTTP transaction to the stream. This way, it is still possible to capture
elements from TCP rules for a full TCP stream. Unfortunately, the release is
still exclusively performed during the HTTP transaction cleanup. Thus, for a TCP
stream where the HTTP transaction is not required, the TCP captures, if any, are
never released.

Now, all captures are released when the stream is freed. This fixes the memory
leak for TCP streams. For streams with an HTTP transaction, the captures are now
released when the transaction is reset and not systematically during its
cleanup.

This patch must be backported as fas as 1.6.

(cherry picked from commit 5939925a3805f9755cff5a3b9635c1a533bc9184)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>

[ Cf: changes in proto_http.c was moved from http_reset_txn() to
      http_end_txn_clean_session() because it is a better place to do some
      cleanup on the stream. But in 2.1, this last functions does not exist
      anymore. ]