tree 42002e991bca65843b871c0961197283120823e2
parent fdc79b9a21c3bb5b95592184949c7582ccd2faf6
author Olivier Houchard <cognet@ci0.org> 1577715222 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1578590066 +0100

BUG/MEDIUM: checks: Only attempt to do handshakes if the connection is ready.

When creating a new check connection, only attempt to add an handshake
connection if the connection has fully been initialized. It can not be the
case if a DNS resolution is still pending, and thus we don't yet have the
address for the server, as the handshake code assumes the connection is fully
initialized and would otherwise crash.
This is not ideal, the check shouldn't probably run until we have an address,
as it leads to check failures with "Socket error".
While I'm there, also add an xprt handshake if we're using socks4, otherwise
checks wouldn't be able to use socks4 properly.
This should fix github issue #430

This should be backported to 2.0 and 2.1.

(cherry picked from commit 37d7897aafc412f3c4a4a68a1dccbd6b5d6cb180)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 68265b3993d68cc7af5fc0f70bcfa35d52ffa99d)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>