commit b1ec21d259c72559e2d170a09efc059d9fc58347
author Tim Duesterhus <tim@bastelstu.be> Sat Apr 22 17:47:32 2023 +0200
committer Willy Tarreau <w@1wt.eu> Sun Apr 23 00:28:25 2023 +0200
tree 816dcc48e096a71df54a966c44f92a8514295e94
parent 3a8c63d48d45cc18b68ab85f1237632e6f4c4f46

CLEANUP: Stop checking the pointer before calling `tasklet_free()`

Changes performed with this Coccinelle patch:

    @@
    expression e;
    @@

    - if (e != NULL) {
    	tasklet_free(e);
    - }

    @@
    expression e;
    @@

    - if (e) {
    	tasklet_free(e);
    - }

    @@
    expression e;
    @@

    - if (e)
    	tasklet_free(e);

    @@
    expression e;
    @@

    - if (e != NULL)
    	tasklet_free(e);

See GitHub Issue #2126

src/stconn.c

diff --git a/src/stconn.c b/src/stconn.c
index 59d2179..8458331 100644
--- a/src/stconn.c
+++ b/src/stconn.c
@@ -231,8 +231,7 @@
 		BUG_ON(!sc_ep_test(sc, SE_FL_DETACHED));
 		sedesc_free(sc->sedesc);
 	}
-	if (sc->wait_event.tasklet)
-		tasklet_free(sc->wait_event.tasklet);
+	tasklet_free(sc->wait_event.tasklet);
 	pool_free(pool_head_connstream, sc);
 }
 
@@ -417,8 +416,7 @@
 	sockaddr_free(&sc->src);
 	sockaddr_free(&sc->dst);
 
-	if (sc->wait_event.tasklet)
-		tasklet_free(sc->wait_event.tasklet);
+	tasklet_free(sc->wait_event.tasklet);
 	sc->wait_event.tasklet = NULL;
 	sc->wait_event.events = 0;
 	sc_free_cond(scp);