commit b1af23ebeaa65353a8de27279bc00372cf10d359
author Thiago Farina <tfarina@chromium.org> Wed Jan 20 23:46:34 2016 +0100
committer Willy Tarreau <w@1wt.eu> Wed Jan 20 23:51:24 2016 +0100
tree 5d32d31ff99f67d50dc611a9f00abc739b87e98a
parent bb107185d1985eb7a45ecb2fe0119b8e8f9b3233

MINOR: fix the return type for dns_response_get_query_id() function

This function should return a 16-bit type as that is the type for
dns header id.
Also because it is doing an uint16 unpack big-endian operation.

Backport: can be backported to 1.6

Signed-off-by: Thiago Farina <tfarina@chromium.org>
Signed-off-by: Baptiste Assmann <bedis9@gmail.com>

include/proto/dns.h

diff --git a/include/proto/dns.h b/include/proto/dns.h
index 80887e8..4ccbfa0 100644
--- a/include/proto/dns.h
+++ b/include/proto/dns.h
@@ -44,6 +44,6 @@
 void dns_update_resolvers_timeout(struct dns_resolvers *resolvers);
 void dns_reset_resolution(struct dns_resolution *resolution);
 int dns_check_resolution_queue(struct dns_resolvers *resolvers);
-int dns_response_get_query_id(unsigned char *resp);
+unsigned short dns_response_get_query_id(unsigned char *resp);
 
 #endif // _PROTO_DNS_H

src/dns.c

diff --git a/src/dns.c b/src/dns.c
index 1348be3..0d8d305 100644
--- a/src/dns.c
+++ b/src/dns.c
@@ -796,7 +796,7 @@
 /*
  * returns the query id contained in a DNS response
  */
-int dns_response_get_query_id(unsigned char *resp)
+unsigned short dns_response_get_query_id(unsigned char *resp)
 {
 	/* read the query id from the response */
 	return resp[0] * 256 + resp[1];