tree 1e88b1caa411fa03fb980c8f82918e70a5f6fa1b
parent 02777a1df5ed217f6646a49509024e35e02edc99
author Willy Tarreau <w@1wt.eu> 1355004208 +0100
committer Willy Tarreau <w@1wt.eu> 1355004453 +0100
encoding latin1

BUG/MEDIUM: tcp: process could theorically crash on lack of source ports

When connect() fails with EAGAIN or EADDRINUSE, an error message is
sent to logs and uses srv->id to indicate the server name (this is
very old code). Since version 1.4, it is possible to have srv == NULL,
so the message could cause a crash when connect() returns EAGAIN or
EADDRINUSE. However in practice this does not happen because on lack
of source ports, EADDRNOTAVAIL is returned instead, so this code is
never called.

This fix consists in not displaying the server name anymore, and in
adding the test for EADDRNOTAVAIL.

Also, the log level was lowered from LOG_EMERG to LOG_ERR in order
not to spam all consoles when source ports are missing for a given
target.

This fix should be backported to 1.4.