DEBUG: stream-int: Check CS_FL_WANT_ROOM is not set with an empty input buffer
In si_cs_recv(), the mux must never set CS_FL_WANT_ROOM flag on the
conn-stream if the input buffer is empty and nothing was copied. It is
important because, there is nothing the app layer can do in this case to
make some room. If this happens, this will most probably lead to a ping-pong
loop between the mux and the stream.
With this BUG_ON(), it will be easier to spot such bugs.
diff --git a/src/stream_interface.c b/src/stream_interface.c
index b78c3bc..c32d566 100644
--- a/src/stream_interface.c
+++ b/src/stream_interface.c
@@ -1377,6 +1377,11 @@
ret = cs->conn->mux->rcv_buf(cs, &ic->buf, max, cur_flags);
if (cs->flags & CS_FL_WANT_ROOM) {
+ /* CS_FL_WANT_ROOM must not be reported if the channel's
+ * buffer is empty.
+ */
+ BUG_ON(c_empty(ic));
+
si_rx_room_blk(si);
/* Add READ_PARTIAL because some data are pending but
* cannot be xferred to the channel