BUG: stream_sock: si->release was not called upon shutw()
The ->release function of the stream interface is never called upon
a shutw() because it's placed after a return statement. It is possible
that it has impacted inter-process stick-table replication by preventing
a full resync after certain sequences of connection breakage. Since this
bug has been present since the introduction of the ->release() callback,
it cannot have caused regressions, just possibly non-working situations.
This was detected at Exceliance by Emeric Brun during a code review. It
is 1.5-specific.
diff --git a/src/stream_sock.c b/src/stream_sock.c
index 8c9f765..44d9e11 100644
--- a/src/stream_sock.c
+++ b/src/stream_sock.c
@@ -885,16 +885,15 @@
case SI_ST_QUE:
case SI_ST_TAR:
si->state = SI_ST_DIS;
+
+ if (si->release)
+ si->release(si);
default:
si->flags &= ~SI_FL_WAIT_ROOM;
si->ib->flags |= BF_SHUTR;
si->ib->rex = TICK_ETERNITY;
si->exp = TICK_ETERNITY;
- return;
}
-
- if (si->release)
- si->release(si);
}
/*