tree 870a4bb577987199fe0b9489a23c0f2a223bd1b7
parent 7783546ea40cab389588ab2f9d3ff72c5e6cda56
author William Lallemand <wlallemand@haproxy.com> 1709050935 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1712157019 +0200

BUG/MINOR: ssl/cli: duplicate cleaning code in cli_parse_del_crtlist

Since 23cab33 ("BUG/MINOR: ssl: Clear the ckch instance when deleting a
crt-list line"), LIST_DELETE is done twice, one time in
cli_parse_del_crtlist() and another time in ckch_inst_free().

It could trigger a crash with -DDEBUG_LIST.

This isn't a major problem since the ptr is not freed in the meantime so
it will only trigger with the debug.

This patch removes the LIST_DELETE as well as the loop done on link_ref
which is also don in ckch_inst_free()

Could be backported as far as 2.4. 2.4 version does not have a link_ref
loop.

(cherry picked from commit bb7af8b2f169647286cfefe516c07d6d3a1fe156)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit e3797580bcce418db2a703389c52a1567cc19a21)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 121cea0cb49fce1c44e9f8c8f634f767c8c6f956)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 9b7f2e71917d74a857ddfd22225d9abbe9724f70)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 8f1d174a925af1efdbbac8c5d15dc07324cb6bb3)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>