commit a9d7b76f6a5824fd2d36ce11fa0a1a1c504f1104
author Willy Tarreau <w@1wt.eu> Fri Jul 10 08:28:20 2020 +0200
committer Willy Tarreau <w@1wt.eu> Fri Jul 10 08:52:13 2020 +0200
tree e840173fe16ad70baa5d0c21e32502bcf1b55155
parent 86891278164d84797406ddcf67c0e11c8b433414

MINOR: connection: use MT_LIST_ADDQ() to add connections to idle lists

When a connection is added to an idle list, it's already detached and
cannot be seen by two threads at once, so there's no point using
TRY_ADDQ, there will never be any conflict. Let's just use the cheaper
ADDQ.

src/backend.c

diff --git a/src/backend.c b/src/backend.c
index 4a162a4..324d756 100644
--- a/src/backend.c
+++ b/src/backend.c
@@ -1345,7 +1345,7 @@
 				if (tokill_conn) {
 					/* We got one, put it into the concerned thread's to kill list, and wake it's kill task */
 
-					MT_LIST_TRY_ADDQ(&idle_conns[i].toremove_conns,
+					MT_LIST_ADDQ(&idle_conns[i].toremove_conns,
 					    (struct mt_list *)&tokill_conn->list);
 					task_wakeup(idle_conns[i].cleanup_task, TASK_WOKEN_OTHER);
 					HA_SPIN_UNLOCK(OTHER_LOCK, &idle_conns[tid].takeover_lock);

src/mux_fcgi.c

diff --git a/src/mux_fcgi.c b/src/mux_fcgi.c
index 7165e39..a0509e6 100644
--- a/src/mux_fcgi.c
+++ b/src/mux_fcgi.c
@@ -2956,9 +2956,9 @@
 		struct server *srv = objt_server(conn->target);
 
 		if (conn_in_list == CO_FL_SAFE_LIST)
-			MT_LIST_TRY_ADDQ(&srv->safe_conns[tid], &conn->list);
+			MT_LIST_ADDQ(&srv->safe_conns[tid], &conn->list);
 		else
-			MT_LIST_TRY_ADDQ(&srv->idle_conns[tid], &conn->list);
+			MT_LIST_ADDQ(&srv->idle_conns[tid], &conn->list);
 	}
 	return NULL;
 }

src/mux_h1.c

diff --git a/src/mux_h1.c b/src/mux_h1.c
index ae3bca3..80a7b7d 100644
--- a/src/mux_h1.c
+++ b/src/mux_h1.c
@@ -2265,9 +2265,9 @@
 		struct server *srv = objt_server(conn->target);
 
 		if (conn_in_list == CO_FL_SAFE_LIST)
-			MT_LIST_TRY_ADDQ(&srv->safe_conns[tid], &conn->list);
+			MT_LIST_ADDQ(&srv->safe_conns[tid], &conn->list);
 		else
-			MT_LIST_TRY_ADDQ(&srv->idle_conns[tid], &conn->list);
+			MT_LIST_ADDQ(&srv->idle_conns[tid], &conn->list);
 	}
 	return NULL;
 }

src/mux_h2.c

diff --git a/src/mux_h2.c b/src/mux_h2.c
index d02a04d..6ec8d27 100644
--- a/src/mux_h2.c
+++ b/src/mux_h2.c
@@ -3565,9 +3565,9 @@
 		struct server *srv = objt_server(conn->target);
 
 		if (conn_in_list == CO_FL_SAFE_LIST)
-			MT_LIST_TRY_ADDQ(&srv->safe_conns[tid], &conn->list);
+			MT_LIST_ADDQ(&srv->safe_conns[tid], &conn->list);
 		else
-			MT_LIST_TRY_ADDQ(&srv->idle_conns[tid], &conn->list);
+			MT_LIST_ADDQ(&srv->idle_conns[tid], &conn->list);
 	}
 
 leave:

src/ssl_sock.c

diff --git a/src/ssl_sock.c b/src/ssl_sock.c
index 54da3a0..69f6835 100644
--- a/src/ssl_sock.c
+++ b/src/ssl_sock.c
@@ -5676,9 +5676,9 @@
 		struct server *srv = objt_server(conn->target);
 
 		if (conn_in_list == CO_FL_SAFE_LIST)
-			MT_LIST_TRY_ADDQ(&srv->safe_conns[tid], &conn->list);
+			MT_LIST_ADDQ(&srv->safe_conns[tid], &conn->list);
 		else
-			MT_LIST_TRY_ADDQ(&srv->idle_conns[tid], &conn->list);
+			MT_LIST_ADDQ(&srv->idle_conns[tid], &conn->list);
 	}
 	return NULL;
 }