BUG/MINOR: pattern: a sample marked as const could be written
The functions add final 0 to string if the final 0 is not set,
but don't check the flag CONST. This patch duplicates the strings
if the final zero is not set and the string is CONST.
Should be backported until 2.2 (at least)
diff --git a/src/pattern.c b/src/pattern.c
index 88e760c..e62d0d0 100644
--- a/src/pattern.c
+++ b/src/pattern.c
@@ -448,11 +448,18 @@
if (smp->data.u.str.data < smp->data.u.str.size) {
/* we may have to force a trailing zero on the test pattern and
- * the buffer is large enough to accommodate it.
+ * the buffer is large enough to accommodate it. If the flag
+ * CONST is set, duplicate the string
*/
prev = smp->data.u.str.area[smp->data.u.str.data];
- if (prev)
- smp->data.u.str.area[smp->data.u.str.data] = '\0';
+ if (prev) {
+ if (smp->flags & SMP_F_CONST) {
+ if (!smp_dup(smp))
+ return NULL;
+ } else {
+ smp->data.u.str.area[smp->data.u.str.data] = '\0';
+ }
+ }
}
else {
/* Otherwise, the sample is duplicated. A trailing zero