BUG/MEDIUM: ssl: check OCSP calloc in ssl_sock_load_ocsp()
Check the return of the calloc in ssl_sock_load_ocsp() which could lead
to a NULL dereference.
This was introduced by commit be2774d ("MEDIUM: ssl: Added support for
Multi-Cert OCSP Stapling").
Could be backported as far as 1.7.
diff --git a/src/ssl_sock.c b/src/ssl_sock.c
index 69f6835..f98c5c0 100644
--- a/src/ssl_sock.c
+++ b/src/ssl_sock.c
@@ -1342,9 +1342,13 @@
SSL_CTX_get_tlsext_status_cb(ctx, &callback);
if (!callback) {
- struct ocsp_cbk_arg *cb_arg = calloc(1, sizeof(*cb_arg));
+ struct ocsp_cbk_arg *cb_arg;
EVP_PKEY *pkey;
+ cb_arg = calloc(1, sizeof(*cb_arg));
+ if (!cb_arg)
+ goto out;
+
cb_arg->is_single = 1;
cb_arg->s_ocsp = iocsp;