tree 1298f79fbcac64afc125ae79ad9c86b525b7dc67
parent 785f3c28d7754aa3536eabbb3c4196f3a0389a39
author Christopher Faulet <cfaulet@haproxy.com> 1589267469 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1589268211 +0200

BUG/MEDIUM: checks: Always initialize checks before starting them

Since the commit c6e077067 ("BUG/MEDIUM: server/checks: Init server check during
config validity check"), a buggy dependency between checks init and checks
startup was introduced using REGISTER_POST_CHECK macros. But the compiler is
free change this order.

Now, only one post-check function is registered. init_servers_checks() function
is responsible to initialize all heath check before starting them calling
start_checks().

The patch was directly introduced on 2.0, there is no upstream commit ID for
this patch. It must be backported everywhere the commit c6e077067 is, at least
to 1.9. For older versions, if the commit c6e077067 is backported, it will
require some changes. So it is not obvious this fix will still be required on
these versions.