BUG/MEDIUM: checks: Always initialize checks before starting them
Since the commit c6e077067 ("BUG/MEDIUM: server/checks: Init server check during
config validity check"), a buggy dependency between checks init and checks
startup was introduced using REGISTER_POST_CHECK macros. But the compiler is
free change this order.
Now, only one post-check function is registered. init_servers_checks() function
is responsible to initialize all heath check before starting them calling
start_checks().
The patch was directly introduced on 2.0, there is no upstream commit ID for
this patch. It must be backported everywhere the commit c6e077067 is, at least
to 1.9. For older versions, if the commit c6e077067 is backported, it will
require some changes. So it is not obvious this fix will still be required on
these versions.
diff --git a/src/checks.c b/src/checks.c
index 2cc6702..f87ba86 100644
--- a/src/checks.c
+++ b/src/checks.c
@@ -3841,13 +3841,12 @@
goto end;
}
}
+ ret = start_checks();
end:
return ret;
}
-/* Must be declared in that order because checks must be initialized first */
REGISTER_POST_CHECK(init_servers_checks);
-REGISTER_POST_CHECK(start_checks);
/*
* Local variables: