BUG/MINOR: http: abort request processing on filter failure
Commit c600204 ("BUG/MEDIUM: regex: fix risk of buffer overrun in
exp_replace()") added a control of failure on the response headers,
but forgot to check for the error during request processing. So if
the filters fail to apply, we could keep the request. It might
cause some headers to silently fail to be added for example. Note
that it's tagged MINOR because a standard configuration cannot make
this case happen.
The fix should be backported to 1.5 and 1.4 though.
(cherry picked from commit 34d4c3c13f0172f0f8f0dd99f92c61e7eb78e98f)
diff --git a/src/proto_http.c b/src/proto_http.c
index 60322d4..705f3b4 100644
--- a/src/proto_http.c
+++ b/src/proto_http.c
@@ -7060,7 +7060,8 @@
/* The filter did not match the request, it can be
* iterated through all headers.
*/
- apply_filter_to_req_headers(s, req, exp);
+ if (unlikely(apply_filter_to_req_headers(s, req, exp) < 0))
+ return -1;
}
}
return 0;