tree ef4f794c518334c986f6c4ffa3f11c8ef8438b5e
parent 7aaac6e0ee7a7c86c3d22aca0eb71cdbd17270f7
author Christopher Faulet <cfaulet@haproxy.com> 1562075283 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1562155286 +0200

BUG/MEDIUM: channel/htx: Use the total HTX size in channel_htx_recv_limit()

The receive limit of an HTX channel must be calculated against the total size of
the HTX message. Otherwise, the buffer may never be seen as full whereas the
receive limit is 0. Indeed, the function channel_htx_full() already takes care
to add a block size to the buffer's reserve (8 bytes). So if the function
channel_htx_recv_limit() also keep a block size free in addition to the buffer's
reserve, it means that at least 2 block size will be kept free but only one will
be taken into account, freezing the stream if the option http-buffer-request is
enabled.

This patch fixes the Github issue #136. It should be backported to 2.0 and
1.9. Thanks jaroslawr (Jarosław Rzeszótko) for his help.

(cherry picked from commit 621da6bafaffc4a0182fb46cfa4b0153c83469e7)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>