tree 5bf7959296024a006abc95c928ef1ac8b7f5442b
parent 7859526fd6ce7ea33e20b7e532b21aa2465cb11d
author Willy Tarreau <w@1wt.eu> 1564146639 +0200
committer Willy Tarreau <w@1wt.eu> 1564148778 +0200
encoding latin1

BUG/MINOR: log: make sure writev() is not interrupted on a file output

Since 1.9 we support sending logs to various non-blocking outputs like
stdou/stderr or flies, by using writev() which guarantees that it only
returns after having written everything or nothing. However the syscall
may be interrupted while doing so, and this is visible when writing to
a tty during debug sessions, as some logs occasionally appear interleaved
if an xterm or SSH connection is not very fast. Performance here is not a
critical concern, log correctness is. Let's simply take the logger's lock
around the writev() call to prevent multiple senders from stepping onto
each other's toes.

This may be backported to 2.0 and 1.9.