MEDIUM: stream: make stream_new() always set the target and analysers
It doesn't make sense that stream_new() doesn't sets the target nor
analysers and that the caller has to do it even if it doesn't know
about streams (eg: in session_accept_fd()). This causes trouble for
H2 where the applet handling the protocol cannot properly change
these information during its init phase.
Let's ensure it's always set and that the callers don't set it anymore.
Note: peers and lua don't use analysers and that's properly handled.
diff --git a/src/session.c b/src/session.c
index 46b9f67..4295777 100644
--- a/src/session.c
+++ b/src/session.c
@@ -116,7 +116,6 @@
struct connection *cli_conn;
struct proxy *p = l->bind_conf->frontend;
struct session *sess;
- struct stream *strm;
struct task *t;
int ret;
@@ -269,13 +268,9 @@
goto out_free_sess;
session_count_new(sess);
- strm = stream_new(sess, t, &cli_conn->obj_type);
- if (!strm)
+ if (!stream_new(sess, t, &cli_conn->obj_type))
goto out_free_task;
- strm->target = sess->listener->default_target;
- strm->req.analysers |= sess->listener->analysers;
-
task_wakeup(t, TASK_WOKEN_INIT);
return 1;
@@ -424,7 +419,6 @@
{
struct task *task = conn->owner;
struct session *sess = task->context;
- struct stream *strm;
if (conn->flags & CO_FL_ERROR)
goto fail;
@@ -439,12 +433,9 @@
session_count_new(sess);
task->process = sess->listener->handler;
- strm = stream_new(sess, task, &conn->obj_type);
- if (!strm)
+ if (!stream_new(sess, task, &conn->obj_type))
goto fail;
- strm->target = sess->listener->default_target;
- strm->req.analysers |= sess->listener->analysers;
conn->flags &= ~CO_FL_INIT_DATA;
task_wakeup(task, TASK_WOKEN_INIT);