tree 5723004dda7bfb7429bd088687ea9ffee01d02a6
parent 1e183b81ee92b1a65c007a5fd30b615409d29198
author William Lallemand <wlallemand@haproxy.org> 1641575982 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1641894835 +0100

BUG/MEDIUM: mworker: don't use _getsocks in wait mode

Since version 2.5 the master is automatically re-executed in wait-mode
when the config is successfully loaded, puting corner cases of the wait
mode in plain sight.

When using the -x argument and with the right timing, the master will
try to get the FDs again in wait mode even through it's not needed
anymore, which will harm the worker by removing its listeners.

However, if it fails, (and it's suppose to, sometimes), the
master will exit with EXIT_FAILURE because it does not have the
MODE_MWORKER flag, but only the MODE_MWORKER_WAIT flag. With the
consequence of killing the workers.

This patch fixes the issue by restricting the use of _getsocks to some
modes.

This patch must be backported in every version supported, even through
the impact should me more harmless in version prior to 2.5.

(cherry picked from commit f82afbb9cd1515e9fa7f9e6df84904b832226304)
Signed-off-by: William Lallemand <wlallemand@haproxy.org>
(cherry picked from commit 9e1927c7e20af70b891eaaa9f88b0dc9d7b570e5)
[cf: MODE_CHECK_CONDITION flag removed]
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>