tree ffa5c739bae81abd37138a530a1d3506ee9b47dc
parent 2151cdd38cbc5ae92362ac471f0c9dddd640a802
author Willy Tarreau <w@1wt.eu> 1595430045 +0200
committer Willy Tarreau <w@1wt.eu> 1595430560 +0200
encoding latin1

CLEANUP: dns: remove 45 "return" statements from dns_validate_dns_response()

The previous leak on do-resolve was particularly tricky to check due
to the important code repetition in dns_validate_dns_response() which
required careful examination of all return statements to check whether
they needed a pool_free() or not. Let's clean all this up using a common
leave point which releases the element itself. This also encourages
to properly set the current response to null right after freeing or
adding it so that it doesn't get added. 45 return and 22 pool_free()
were replaced by one of each.