tree c055f7fc106d86b75c18b4204aadb41512cacf57
parent c13d9e1e1e925a24d5c2347076d359b514f24943
author Amaury Denoyelle <adenoyelle@haproxy.com> 1708528243 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1711722814 +0100

BUG/MINOR: ist: allocate nul byte on istdup

istdup() is documented as having the same behavior as strdup(). However,
it may cause confusion as it allocates a block of input length, without
an extra byte for \0 delimiter. This behavior is incoherent as in case
of an empty string however a single \0 is allocated.

This API inconsistency could cause a bug anywhere an IST is used as a
C-string after istdup() invocation. Currently, the only found issue is
with 'wait' CLI command using 'srv-unused'. This causes a buffer
overflow due to ist0() invocation after istdup() for be_name and
sv_name.

Backport should be done to all stable releases. Even if no bug has been
found outside of wait CLI implementation, it ensures the code is more
consistent on every releases.

(cherry picked from commit de02167584606d02872e8f0918c882709bec6a80)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit e86b121b57ac74d97f974f8476ea431578a3d852)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>