BUG/MINOR: standard: Avoid free of non-allocated pointer
The original author forgot to dereference the argument to free in
parse_binary. This may result in a crash on reading bad input from
the configuration file instead of a proper error message.
Found in HAProxy 1.5.14.
diff --git a/src/standard.c b/src/standard.c
index 30883d7..40727b0 100644
--- a/src/standard.c
+++ b/src/standard.c
@@ -2052,8 +2052,10 @@
bad_input:
memprintf(err, "an hex digit is expected (found '%c')", p[i-1]);
- if (alloc)
- free(binstr);
+ if (alloc) {
+ free(*binstr);
+ *binstr = NULL;
+ }
return 0;
}