tree de32d2cd08d9cf7c77f7129f139da17a1c7c6cfb
parent 7e8c0165063b820e80790f0ecb7504f50a3562d4
author Tim Duesterhus <tim@bastelstu.be> 1574549110 +0100
committer Willy Tarreau <w@1wt.eu> 1574738216 +0100
encoding latin1

CLEANUP: ssl: Clean up error handling

This commit removes the explicit checks for `if (err)` before
passing `err` to `memprintf`. `memprintf` already checks itself
whether the `**out*` parameter is `NULL` before doing anything.
This reduces the indentation depth and makes the code more readable,
before there is less boilerplate code.

Instead move the check into the ternary conditional when the error
message should be appended to a previous message. This is consistent
with the rest of ssl_sock.c and with the rest of HAProxy.

Thus this patch is the arguably cleaner fix for issue #374 and builds
upon
5f1fa7db86c53827c97f8a8c3f5fa75bfcb5be9a and
8b453912ce9a4e1a3b1329efb2af04d1e470852e

Additionally it fixes a few places where the check *still* was missing.