tree eab06cdef9f87d9cac6452248b5b80cd2d8cba66
parent 806c5c5e3c8928795f937362bf94e26a91909332
author Willy Tarreau <w@1wt.eu> 1719721410 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1719995715 +0200

BUG/MEDIUM: quic: fix possible exit from qc_check_dcid() without unlocking

Locking of the CID tree was extended in qc_check_dcid() by recent commit
05f59a5 ("BUG/MINOR: quic: fix race condition in qc_check_dcid()") but
there was a direct return from the middle of the function which was not
covered by the unlock, resulting in the function keeping the lock on
success return.

Let's just remove this return and replace it with a variable to merge all
exit paths.

This must be backported wherever the fix above is backported.

(cherry picked from commit 192abc6f834dcd09f310299afe253b17f9985407)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 01e25a4cf2ce667745fb04c01153f3d9f56cc8ba)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 59bd950e0561aca21695afba0c30241aa2cbf14a)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>