tree 98fc8fe225bf5ed0f0ec2a7d0546ed55d16a79cf
parent 326ec91601411ef04f419a928f146b85f3c5e296
author Amaury Denoyelle <adenoyelle@haproxy.com> 1722242570 +0200
committer Willy Tarreau <w@1wt.eu> 1725550002 +0200
encoding latin1

BUG/MEDIUM: quic: prevent conn freeze on 0RTT undeciphered content

Received QUIC packets are stored in quic_conn Rx buffer after header
protection removal in qc_rx_pkt_handle(). These packets are then removed
after quic_conn IO handler via qc_treat_rx_pkts().

If HP cannot be removed, packets are still copied into quic_conn Rx
buffer. This can happen if encryption level TLS keys are not yet
available. The packet remains in the buffer until HP can be removed and
its content processed.

An issue occurs if client emits a 0-RTT packet but haproxy does not have
the shared secret, for example after a haproxy process restart. In this
case, the packet is copied in quic_conn Rx buffer but its HP won't ever
be removed. This prevents the buffer to be purged. After some time, if
the client has emitted enough packets, Rx buffer won't have any space
left and received packets are dropped. This will cause the connection to
freeze.

To fix this, remove any 0-RTT buffered packets on handshake completion.
At this stage, 0-RTT packets are unnecessary anymore. The client is
expected to reemit its content in 1-RTT packet which are properly
deciphered.

This can easily reproduce with HTTP/3 POST requests or retrieving a big
enough object, which will fill the Rx buffer with ACK frames. Here is a
picoquic command to provoke the issue on haproxy startup :

$ picoquicdemo -Q -v 00000001 -a h3 <hostname> 20443 "/?s=1g"

Note that allow-0rtt must be present on the bind line to trigger the
issue. Else haproxy will reject any 0-RTT packets.

This must be backported up to 2.6.

This could be one of the reason for github issue #2549 but it's unsure
for now.

(cherry picked from commit bba6baff306820a01ea66fddde5acbad11c601b6)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 0a06f5f5aefdba68c675f9c2bf55dad093f800e7)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit c1f51cecce9e7dc926527729d26ace8750b8ca64)
[wt: qc->eel => qc->els[QUIC_TLS_ENC_LEVEL_EARLY_DATA] (no dyn alloc)]
Signed-off-by: Willy Tarreau <w@1wt.eu>