BUG/MINOR: tools: Fix a memory leak on error path in parse_dotted_uints()
When an invalid character is found during parsing in parse_dotted_uints()
function, the allocated array of uint must be released. This patch fixes a
memory leak on error path during the configuration parsing.
This patch should fix the issue #1106. It should be backported as far as
2.0. Note that, for 2.1 and 2.0, the function is in src/standard.c
(cherry picked from commit 4b524124db9dc6e64b4e0f0882b5fc71d24970e0)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
diff --git a/src/tools.c b/src/tools.c
index 9a821e5..1c8a285 100644
--- a/src/tools.c
+++ b/src/tools.c
@@ -4709,8 +4709,10 @@
/* Expected characters after having read an uint: '\0' or '.',
* if '.', must not be terminal.
*/
- if (*s != '\0'&& (*s++ != '.' || s == end))
+ if (*s != '\0'&& (*s++ != '.' || s == end)) {
+ free(n);
return 0;
+ }
n = my_realloc2(n, (*sz + 1) * sizeof *n);
if (!n)