tree 93f08b85d070fe2b28d3e196cec586e5cfdb4537
parent 8844b454a08c590fb67dcac577c62508825158fc
author William Lallemand <wlallemand@haproxy.org> 1579185128 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1579526368 +0100

BUG/MEDIUM: cli: _getsocks must send the peers sockets

This bug prevents to reload HAProxy when you have both the seamless
reload (-x / expose-fd listeners) and the peers.

Indeed the _getsocks command does not send the FDs of the peers
listeners, so if no reuseport is possible during the bind, the new
process will fail to bind and exits.

With this feature, it is not possible to fallback on the SIGTTOU method
if we didn't receive all the sockets, because you can't close() the
sockets of the new process without closing those of the previous
process, they are the same.

Should fix bug #443.

Must be backported as far as 1.8.

(cherry picked from commit 5fd3b28c9c071376a9bffb427b25872ffc068601)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 53f802b06a8c165c39cb1b9a3455366e1293d1ed)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>