MEDIUM: init: use initcall for all fixed size pool creations
This commit replaces the explicit pool creation that are made in
constructors with a pool registration. Not only this simplifies the
pools declaration (it can be done on a single line after the head is
declared), but it also removes references to pools from within
constructors. The only remaining create_pool() calls are those
performed in init functions after the config is parsed, so there
is no more user of potentially uninitialized pool now.
It has been the opportunity to remove no less than 12 constructors
and 6 init functions.
diff --git a/src/connection.c b/src/connection.c
index 6214775..054e199 100644
--- a/src/connection.c
+++ b/src/connection.c
@@ -30,8 +30,9 @@
#include <proto/ssl_sock.h>
#endif
-struct pool_head *pool_head_connection;
-struct pool_head *pool_head_connstream;
+DECLARE_POOL(pool_head_connection, "connection", sizeof(struct connection));
+DECLARE_POOL(pool_head_connstream, "conn_stream", sizeof(struct conn_stream));
+
struct xprt_ops *registered_xprt[XPRT_ENTRIES] = { NULL, };
/* List head of all known muxes for PROTO */
@@ -39,25 +40,6 @@
.list = LIST_HEAD_INIT(mux_proto_list.list)
};
-/* perform minimal intializations, report 0 in case of error, 1 if OK. */
-int init_connection()
-{
- pool_head_connection = create_pool("connection", sizeof (struct connection), MEM_F_SHARED);
- if (!pool_head_connection)
- goto fail_conn;
-
- pool_head_connstream = create_pool("conn_stream", sizeof(struct conn_stream), MEM_F_SHARED);
- if (!pool_head_connstream)
- goto fail_cs;
-
- return 1;
- fail_cs:
- pool_destroy(pool_head_connection);
- pool_head_connection = NULL;
- fail_conn:
- return 0;
-}
-
/* I/O callback for fd-based connections. It calls the read/write handlers
* provided by the connection's sock_ops, which must be valid.
*/