CLEANUP: tcp/unix: remove useless NULL check in {tcp,unix}_bind_listener()
errmsg may only be NULL if errlen is zero. Clarify this in the comment too.
Reported-by: Dinko Korunic <dkorunic@reflected.net>
diff --git a/src/proto_tcp.c b/src/proto_tcp.c
index 7285457..60b111c 100644
--- a/src/proto_tcp.c
+++ b/src/proto_tcp.c
@@ -550,8 +550,9 @@
/* This function tries to bind a TCPv4/v6 listener. It may return a warning or
- * an error message in <err> if the message is at most <errlen> bytes long
- * (including '\0'). The return value is composed from ERR_ABORT, ERR_WARN,
+ * an error message in <errmsg> if the message is at most <errlen> bytes long
+ * (including '\0'). Note that <errmsg> may be NULL if <errlen> is also zero.
+ * The return value is composed from ERR_ABORT, ERR_WARN,
* ERR_ALERT, ERR_RETRYABLE and ERR_FATAL. ERR_NONE indicates that everything
* was alright and that no message was returned. ERR_RETRYABLE means that an
* error occurred but that it may vanish after a retry (eg: port in use), and
@@ -568,7 +569,7 @@
const char *msg = NULL;
/* ensure we never return garbage */
- if (errmsg && errlen)
+ if (errlen)
*errmsg = 0;
if (listener->state != LI_ASSIGNED)