BUILD: definitely silence some stupid GCC warnings
It's becoming increasingly difficult to ignore unwanted function returns in
debug code with gcc. Now even when you try to work around it, it suggests a
way to write your code differently. For example :
src/frontend.c:187:65: warning: if statement has empty body [-Wempty-body]
if (write(1, trash.str, trash.len) < 0) /* shut gcc warning */;
^
src/frontend.c:187:65: note: put the semicolon on a separate line to silence this warning
1 warning generated.
This is totally unacceptable, this code already had to be written this way
to shut it up in earlier versions. And now it comments the form ? What's the
purpose of the C language if you can't write anymore the code that does what
you want ?
Emeric proposed to just keep a global variable to drain such useless results
so that gcc stops complaining all the time it believes people who write code
are monkeys. The solution is acceptable because the useless assignment is done
only in debug code so it will not impact performance. This patch implements
this, until gcc becomes even "smarter" to detect that we tried to cheat.
diff --git a/src/session.c b/src/session.c
index 86dcb84..21fea39 100644
--- a/src/session.c
+++ b/src/session.c
@@ -2359,7 +2359,7 @@
s->uniq_id, s->be->id,
objt_conn(s->si[0].end) ? (unsigned short)objt_conn(s->si[0].end)->t.sock.fd : -1,
objt_conn(s->si[1].end) ? (unsigned short)objt_conn(s->si[1].end)->t.sock.fd : -1);
- if (write(1, trash.str, trash.len) < 0) /* shut gcc warning */;
+ shut_your_big_mouth_gcc(write(1, trash.str, trash.len));
}
if (s->si[0].state == SI_ST_CLO &&
@@ -2368,7 +2368,7 @@
s->uniq_id, s->be->id,
objt_conn(s->si[0].end) ? (unsigned short)objt_conn(s->si[0].end)->t.sock.fd : -1,
objt_conn(s->si[1].end) ? (unsigned short)objt_conn(s->si[1].end)->t.sock.fd : -1);
- if (write(1, trash.str, trash.len) < 0) /* shut gcc warning */;
+ shut_your_big_mouth_gcc(write(1, trash.str, trash.len));
}
}
@@ -2473,7 +2473,7 @@
s->uniq_id, s->be->id,
objt_conn(s->si[0].end) ? (unsigned short)objt_conn(s->si[0].end)->t.sock.fd : -1,
objt_conn(s->si[1].end) ? (unsigned short)objt_conn(s->si[1].end)->t.sock.fd : -1);
- if (write(1, trash.str, trash.len) < 0) /* shut gcc warning */;
+ shut_your_big_mouth_gcc(write(1, trash.str, trash.len));
}
s->logs.t_close = tv_ms_elapsed(&s->logs.tv_accept, &now);