tree 394d75559130d1c8691ebdfbfe6340dc3da5eb7c
parent 6cfe787124fae40e8d617a104750d838abbf59a5
author Willy Tarreau <w@1wt.eu> 1700473461 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1705501765 +0100

BUG/MINOR: sock: mark abns sockets as non-suspendable and always unbind them

In 2.3, we started to get a cleaner socket unbinding mechanism with
commit f58b8db47 ("MEDIUM: receivers: add an rx_unbind() method in
the protocols"). This mechanism rightfully refrains from unbinding
when sockets are expected to be transferrable to another worker via
"expose-fd listeners", but this is not compatible with ABNS sockets,
which do not support reuseport, unbinding nor being renamed: in short
they will always prevent a new process from binding.

It turns out that this is not much visible because by pure accident,
GTUNE_SOCKET_TRANSFER is only set in the code dealing with master mode
and deamons, so it's never set in foreground mode nor in tests even if
present on the stats socket. However with master mode, it is now always
set even when not present on the stats socket, and will always conflict.

The only reasonable approach seems to consist in marking these abns
sockets as non-suspendable so that the generic sock_unbind() code can
decide to just unbind them regardless of GTUNE_SOCKET_TRANSFER.

This should carefully be backported as far as 2.4.

(cherry picked from commit 445fc1fe3a0dd6a9d43790f5848d1d22b0c0dcba)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 3ecb34153915ad6fae933241128862c1c045449f)
[cf: ctx adjt]
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit b8252550bc615ca61a9805ac3d8ef37b5d537862)
[cf: ctx adjt]
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 6b86fcbee381a705bbcab12feaa409b2ff9deac1)
[cf: ctx adjt]
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>