tree c1aadd34b73189c149135e94f53d548d2bd3f01c
parent 7c71822669fe7ff3b55d85c2cf3d3009e830d201
author Willy Tarreau <w@1wt.eu> 1651051993 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1651234906 +0200

BUG/MINOR: pools: make sure to also destroy shared pools in pool_destroy_all()

In issue #1677, Tim reported that we don't correctly free some shared
pools on exit. What happens in fact is that pool_destroy() is meant to
be called once per pool *pointer*, as it decrements the use count for
each pass and only releases the pool when it reaches zero. But since
pool_destroy_all() iterates over the pools list, it visits each pool
only once and will not eliminate some of them, which thus remain in the
list.

In an ideal case, the function should loop over all pools for as long
as the list is not empty, but that's pointless as we know we're exiting,
so let's just set the users count to 1 before the call so that
pool_destroy() knows it can delete and release the entry.

This could be backported to all versions (memory.c in 2.0 and older) but
it's not a real problem in practice.

(cherry picked from commit 243e68b552b1d27dd8f86c35394551c124652ed2)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit b71648fa9a89946752cb9d0423f314fbc4642803)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>