tree 6176a5c1ed7802a3fab52f26f8a6fa3be7b10ed4
parent 53c250e1656dda7c9fcece5b688f0f3a9a3ec068
author Willy Tarreau <w@1wt.eu> 1421869167 +0100
committer Willy Tarreau <w@1wt.eu> 1421869500 +0100
encoding latin1

BUG/MEDIUM: http: make http-request set-header compute the string before removal

The way http-request/response set-header works is stupid. For a naive
reuse of the del-header code, it removes all occurrences of the header
to be set before computing the new format string. This makes it almost
unusable because it is not possible to append values to an existing
header without first copying them to a dummy header, performing the
copy back and removing the dummy header.

Instead, let's share the same code as add-header and perform the optional
removal after the string is computed. That way it becomes possible to
write things like :

   http-request set-header X-Forwarded-For %[hdr(X-Forwarded-For)],%[src]

Note that this change is not expected to have any undesirable impact on
existing configs since if they rely on the bogus behaviour, they don't
work as they always retrieve an empty string.

This fix must be backported to 1.5 to stop the spreadth of ugly configs.