tree 7b6ca2394487c19f8288e9beb7a3c69e2308b6a0
parent b4c5e93779bef9dcc31088bedec87c4ef58f885b
author Olivier Houchard <cognet@ci0.org> 1577726140 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1578590066 +0100

BUG/MEDIUM: connections: Hold the lock when wanting to kill a connection.

In connect_server(), when we decide we want to kill the connection of
another thread because there are too many idle connections, hold the
toremove_lock of the corresponding thread, othervise, there's a small race
condition where we could try to add the connection to the toremove_connections
list while it has already been free'd.

This should be backported to 2.0 and 2.1.

(cherry picked from commit 140237471e408736bb7162e68c572c710a66a526)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 000f227a4cfdb019575e889638f9e0e5a53bbb0b)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>