tree 439e09d526003e863291e6b3f9aa0892fdca4edc
parent de2ba8640b0113071ef3cf668a194052fffaf510
author Frédéric Lécaille <flecaille@haproxy.com> 1680432202 +0200
committer Frédéric Lécaille <flecaille@haproxy.com> 1680433813 +0200

BUG/MAJOR: quic: Congestion algorithms states shared between the connection

This very old bug is there since the first implementation of newreno congestion
algorithm implementation. This was a very bad idea to put a state variable
into quic_cc_algo struct which only defines the congestion control algorithm used
by a QUIC listener, typically its type and its callbacks.
This bug could lead to crashes since BUG_ON() calls have been added to each algorithm
implementation. This was revealed by interop test, but not very often as there was
not very often several connections run at the time during these tests.

Hopefully this was also reported by Tristan in GH #2095.

Move the congestion algorithm state to the correct structures which are private
to a connection (see cubic and nr structs).

Must be backported to 2.7 and 2.6.