MINOR: quic: add a TODO for a memleak frame on ACK consume
The quic_frame instance containing the quic_stream must be freed when
the corresponding ACK has been received. However when implementing this
on qcs_try_to_consume, some data transfers are interrupted and cannot
complete (DC test from interop test suite).
diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index 3e63187..6f92849 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -1414,6 +1414,18 @@
frm_node = eb64_next(frm_node);
eb64_delete(&strm->offset);
+
+ /* TODO
+ *
+ * memleak: The quic_frame container of the quic_stream should
+ * be liberated here, as in qc_treat_acked_tx_frm. However this
+ * code seems to cause a bug which can lead to interrupted
+ * transfers.
+ *
+ * struct quic_frame frm = container_of(strm, struct quic_frame, stream);
+ * LIST_DELETE(&frm->list);
+ * pool_free(pool_head_quic_frame, frm);
+ */
}
return ret;